Drop support for Python 3.8 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtmm
force-pushed
the
drop-python3.8
branch
2 times, most recently
from
25fad14
to
8497783
Compare
fghaas
reviewed
Oct 2, 2024
fghaas
reviewed
Oct 2, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,10 @@ | |||
| ## Unreleased | |||
|
|
|||
| * [Enhancement] Drop support for Python 3.8; Update the Ubuntu base image to | |||
There was a problem hiding this comment.
I understand I am nitpicking, but a semicolon does not trigger capitalisation of the next word.
Thus, either use:
Suggested change
| * [Enhancement] Drop support for Python 3.8; Update the Ubuntu base image to | |
| * [Enhancement] Drop support for Python 3.8. Update the Ubuntu base image to |
... or else, use:
Suggested change
| * [Enhancement] Drop support for Python 3.8; Update the Ubuntu base image to | |
| * [Enhancement] Drop support for Python 3.8; update the Ubuntu base image to |
Python 3.8 will end security support on 2024-10-31; * Drop support for Python 3.8 in this plugin * Update the Ubuntu base image to Jammy (22.04)
fghaas
approved these changes
Oct 2, 2024
|
I've dropped the Python 3.8 check from the list of required checks for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.