fix: Update django-storages options #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Open edX Quince release comes with a new django-storages version (1.14). New versions of django-storages have stricter checks for STORAGE_KWARGS. It is no longer allowed to have options from other storage classes, such as base_url, which is irrelevant to the S3 storage class. The bucket option has also been removed. It has been named bucket_name since django-storages 1.7 (even Open edX Lilac used 1.8, so there are no backward compatibility concerns); 1.10 dropped the "bucket" alias. Co-authored-by: Florian Haas <[email protected]>
fghaas
force-pushed
the
fix-grade-storage-kwargs
branch
from
3edce0e
to
0d16f7e
Compare
|
Hey @fghaas |
Closed
mrtmm
approved these changes
Feb 21, 2024
|
@CefBoud We've tagged |
|
@fghaas Thank you for the head's up. Much appreciated. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Open edX Quince release comes with a new django-storages version (1.14).
New versions of django-storages have stricter checks for
STORAGE_KWARGS. It is no longer allowed to have options from other storage classes, such asbase_url, which is irrelevant to the S3 storage class.The
bucketoption has also been removed. It has been namedbucket_namesince django-storages 1.7 (even Open edX Lilac used 1.8, so there are no backward compatibility concerns); 1.10 dropped thebucketalias.