-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump supported tutor versions to work on tutor 18 for redwood #76
chore: bump supported tutor versions to work on tutor 18 for redwood #76
Conversation
28bc5a7
to
e1a27ac
Compare
@kaustavb12 Please note that we won't merge this until (a) Tutor 18 is out, and (b) you or someone else tests and confirms that this plugin does work correctly with Tutor 18. Rationale: with Tutor 17, we had a similar "chore" PR (#66), which resulted in subsequent breakage that had to be separately fixed (#70), and we'd like to avoid that this time around. |
Ack !! I marked it as draft pending verification that it works correctly. |
@kaustavb12 I have done a basic sanity check as a part of the testing Grove for Redwood support. I uploaded a couple of files in the studio and generated the profile data as mentioned in the PR #70. I didn't encounter any issues. Just adding it here, in case you are planning more extensive tests later. |
@fghaas FYI about the latest comment |
Thanks a lot @tecoholic @fghaas This PR branch has been in use to spin-up a number of sandboxes for Axim in the last month, and no issue has been reported so far. Are we good to merge this ? I could spin up a sandbox and share the links here if that would help. cc. @gabor-boros |
@kaustavb12 I think so, but we were still waiting for you to mark this PR as Ready for review. :) |
@fghaas Oops .. sorry about that 😄 This is now ready for review. |
@kaustavb12 I'm a little stumped by the fact that GitHub is apparently waiting for the checks to complete, but they never ran, and I seem to have no way to retrigger them. Can I ask for a favour? Could you please run (in your local checkout of this topic branch) git commit --amend --no-edit
git push --force-with-lease That way we'll hopefully coax GitHub Actions into rescheduling the workflow. |
Update the install_requires list to include support for Tutor 18 (and Open edX Redwood), and update the README.
e1a27ac
to
1a6c595
Compare
@fghaas Force pushed. It says waiting for approval from a maintainer to run the workflow. |
Yes, that bit is expected. I've cleared the workflow to run now. |
@mrtmm, this PR is now no longer a Draft, and all checks pass. Please review and merge at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thanks!
Description
Add support for tutor 18 (Redwood)
Other information
Private Ref : OpenCraft Internal ticket BB-8942