Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump supported tutor versions to work on tutor 18 for redwood #76

Merged

Conversation

kaustavb12
Copy link
Contributor

@kaustavb12 kaustavb12 commented Jun 14, 2024

Description

Add support for tutor 18 (Redwood)

Other information

Private Ref : OpenCraft Internal ticket BB-8942

@kaustavb12 kaustavb12 marked this pull request as draft June 14, 2024 11:41
@kaustavb12 kaustavb12 force-pushed the kaustav/bump_supported_tutor_versions_18 branch from 28bc5a7 to e1a27ac Compare June 14, 2024 11:47
@fghaas
Copy link
Contributor

fghaas commented Jun 14, 2024

@kaustavb12 Please note that we won't merge this until (a) Tutor 18 is out, and (b) you or someone else tests and confirms that this plugin does work correctly with Tutor 18.

Rationale: with Tutor 17, we had a similar "chore" PR (#66), which resulted in subsequent breakage that had to be separately fixed (#70), and we'd like to avoid that this time around.

@kaustavb12
Copy link
Contributor Author

@fghaas

Ack !! I marked it as draft pending verification that it works correctly.
I am currently in the process of deploying redwood sandboxes for testing.

@tecoholic
Copy link

@kaustavb12 I have done a basic sanity check as a part of the testing Grove for Redwood support. I uploaded a couple of files in the studio and generated the profile data as mentioned in the PR #70. I didn't encounter any issues. Just adding it here, in case you are planning more extensive tests later.

@gabor-boros
Copy link
Contributor

@fghaas FYI about the latest comment

@kaustavb12
Copy link
Contributor Author

Thanks a lot @tecoholic

@fghaas This PR branch has been in use to spin-up a number of sandboxes for Axim in the last month, and no issue has been reported so far. Are we good to merge this ?

I could spin up a sandbox and share the links here if that would help.

cc. @gabor-boros

@fghaas
Copy link
Contributor

fghaas commented Aug 7, 2024

@fghaas This PR branch has been in use to spin-up a number of sandboxes for Axim in the last month, and no issue has been reported so far. Are we good to merge this ?

@kaustavb12 I think so, but we were still waiting for you to mark this PR as Ready for review. :)

@kaustavb12 kaustavb12 marked this pull request as ready for review August 8, 2024 08:42
@kaustavb12
Copy link
Contributor Author

kaustavb12 commented Aug 8, 2024

@fghaas Oops .. sorry about that 😄

This is now ready for review.

@fghaas
Copy link
Contributor

fghaas commented Aug 8, 2024

@kaustavb12 I'm a little stumped by the fact that GitHub is apparently waiting for the checks to complete, but they never ran, and I seem to have no way to retrigger them.

Can I ask for a favour? Could you please run (in your local checkout of this topic branch)

git commit --amend --no-edit
git push --force-with-lease

That way we'll hopefully coax GitHub Actions into rescheduling the workflow.

Update the install_requires list to include support for Tutor 18 (and
Open edX Redwood), and update the README.
@kaustavb12 kaustavb12 force-pushed the kaustav/bump_supported_tutor_versions_18 branch from e1a27ac to 1a6c595 Compare August 8, 2024 10:20
@kaustavb12
Copy link
Contributor Author

@fghaas Force pushed. It says waiting for approval from a maintainer to run the workflow.

@fghaas
Copy link
Contributor

fghaas commented Aug 8, 2024

@fghaas Force pushed. It says waiting for approval from a maintainer to run the workflow.

Yes, that bit is expected. I've cleared the workflow to run now.

@fghaas fghaas requested a review from mrtmm August 8, 2024 11:28
@fghaas
Copy link
Contributor

fghaas commented Aug 8, 2024

@mrtmm, this PR is now no longer a Draft, and all checks pass. Please review and merge at your convenience.

Copy link

@mrtmm mrtmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks!

@mrtmm mrtmm merged commit 1a6c595 into hastexo:main Aug 8, 2024
5 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/bump_supported_tutor_versions_18 branch August 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants