Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow catalog downgrade through CLI #1156

Closed
rakeshkky opened this issue Dec 3, 2018 · 2 comments
Closed

allow catalog downgrade through CLI #1156

rakeshkky opened this issue Dec 3, 2018 · 2 comments
Labels
c/server Related to server e/intermediate can be wrapped up in a week k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint

Comments

@rakeshkky
Copy link
Member

No description provided.

@rakeshkky rakeshkky added k/enhancement New feature or improve an existing feature c/cli Related to CLI p/longterm Low priority issues that will be picked up based on user feedback or bandwidth labels Dec 3, 2018
@0x777
Copy link
Member

0x777 commented Dec 3, 2018

When we bump the catalog version it is not possible to revert to an earlier version of graphql-engine.

@dsandip
Copy link
Member

dsandip commented Feb 27, 2019

Just to clarify @0x777's comment, this is doable and will be considered for one of the upcoming releases. Please add a 👍 to prioritize this higher.

@shahidhk shahidhk added the e/intermediate can be wrapped up in a week label Nov 20, 2019
@shahidhk shahidhk removed their assignment Nov 20, 2019
@lexi-lambda lexi-lambda added c/server Related to server p/high candidate for being included in the upcoming sprint and removed c/cli Related to CLI p/longterm Low priority issues that will be picked up based on user feedback or bandwidth labels Jan 8, 2020
@0x777 0x777 closed this as completed in 94102c0 Feb 7, 2020
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
* Add downgrade command

* Add docs per @lexi-lambda's suggestions

* make tests pass

* Update hdb_version once, from Haskell

* more work based on feedback

* Improve the usage message

* Small docs changes

* Test downgrades exist for each tag

* Update downgrading.rst

* Use git-log to find tags which are ancestors of the current commit

Co-authored-by: Vamshi Surabhi <[email protected]>
hasura-bot pushed a commit that referenced this issue Apr 16, 2021
hasura-bot pushed a commit that referenced this issue Sep 25, 2024
<!-- The PR description should answer 2 important questions: -->

### What

We are going to need tests for our OpenDD IR pipeline, and we are going
to need to convert GraphQL requests into OpenDD IR at some point, so
this makes the most basic `normalized_ast -> OpenDD IR QueryRequest`
pipeline and implements / tests it for the simplest possible query.

This only affects tests at this point, so is a functional no-op.

### How

This PR adds the most basic `normalized_ast -> OpenDD IR QueryRequest`
pipeline and implements / tests it for the simplest possible query.

```rust
enum TestOpenDDPipeline {
    Skip,
    GenerateOpenDDQuery,
    GenerateExecutionPlan,
}
```

It adds a flag for each engine test to opt-in for testing with the new
pipeline. Currently one passes `GenerateOpenDDQuery`, and tests the
result against a snapshot, and the rest pass `Skip`.

The unblocks two following steps:
- we can improve the GraphQL -> OpenDD IR generation, enabling more
tests by passing `GenerateOpenDDQuery`
- once the main new `plan` pipeline generates the same types as the
existing `execute` crate, we can compare the old `execute::plan` with
the new one, and enable that per test by passing
`GenerateExecutionPlan`.

Once all the tests are passing `GenerateExecutionPlan` we can remove the
flag and we know we'll have parity in plan creation.

V3_GIT_ORIGIN_REV_ID: 607dfce77b68849c7fc66fc652e38182fa0c83ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server e/intermediate can be wrapped up in a week k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint
Projects
None yet
Development

No branches or pull requests

5 participants