Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ciignore and check build worthiness #1161

Closed
shahidhk opened this issue Dec 4, 2018 · 0 comments
Closed

fix ciignore and check build worthiness #1161

shahidhk opened this issue Dec 4, 2018 · 0 comments
Labels
c/build-system Related to the build-release system

Comments

@shahidhk
Copy link
Member

shahidhk commented Dec 4, 2018

Need to improve the logic on checking whether to build or not.
@shahidhk shahidhk added the c/build-system Related to the build-release system label Dec 4, 2018
@shahidhk shahidhk mentioned this issue Mar 6, 2019
Merged
hasura-bot pushed a commit that referenced this issue Sep 27, 2024
@danieljharvey @hasura-bot
Move NdcFieldAlias to new plan-types crate (#1161)
b13cd46 
### What

We'd like to use `NdcFieldAlias` in the `plan` crate, however because of
the ways deps between `graphql_ir` and `execute` work we cannot without
a cycle. Functional no-op.

### How

Create a new crate that depends on nothing for planning-related domain
types.

V3_GIT_ORIGIN_REV_ID: c441f2de2eba01bda59ce16e1e4b0e4d9f765d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/build-system Related to the build-release system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shahidhk