Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable inserting multi line data in tables through console #1742

Closed
wawhal opened this issue Mar 12, 2019 · 6 comments
Closed

enable inserting multi line data in tables through console #1742

wawhal opened this issue Mar 12, 2019 · 6 comments
Assignees
Labels
c/console Related to console good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! k/bug Something isn't working p/high candidate for being included in the upcoming sprint

Comments

@wawhal
Copy link
Contributor

wawhal commented Mar 12, 2019

Issue comes from @henriquea on Discord

He wanted to store markdown input into the database and wanted to test by inserting values from the console but the console strips out line breaks.

@wawhal wawhal added k/bug Something isn't working help wanted Good candidate for contribution. Community help wanted! good first issue Good for newcomers c/console Related to console labels Mar 12, 2019
@hnqso
Copy link

hnqso commented Mar 12, 2019

Thanks for this @wawhal! I think a good rule of thumb here is that console apart from sanitising and preventing XSS, it shouldn't mutate the data at all. Empty spaces, new lines, etc should be handled by the developer itself.

@rohitsanj
Copy link

I'd like to work on this issue. Can anyone guide me as to how I can go about enabling multi-line inserts? I'm assuming I'll have to delete some part of the code which strips new lines.

As @henriquea said, it should be up to the developer to control the type of data being input.

@dsandip dsandip added the p/high candidate for being included in the upcoming sprint label May 13, 2019
@rikinsk-zz
Copy link

related to: #504

@mnlbox
Copy link
Contributor

mnlbox commented May 13, 2019

@rikinsk It's not only about JSON editor. Multi line text input (textarea) also very useful for simple Text column for example like description fields in many tables. 😉

@mnlbox
Copy link
Contributor

mnlbox commented May 15, 2019

@rikinsk we have open PR here: #1155 🤔

@rikinsk-zz
Copy link

closing in favour of #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! k/bug Something isn't working p/high candidate for being included in the upcoming sprint
Projects
None yet
Development

No branches or pull requests

7 participants