Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update realtime poll and location tracking apps #1066

Merged
merged 4 commits into from
Nov 20, 2018
Merged

update realtime poll and location tracking apps #1066

merged 4 commits into from
Nov 20, 2018

Conversation

karthikvt26
Copy link
Contributor

Update favicon for realtime-location-app.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk changed the title Update favicon update realtime poll and location tracking apps Nov 20, 2018
@shahidhk shahidhk merged commit 1b16582 into hasura:master Nov 20, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1066.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Sep 11, 2024
@ecthiender @hasura-bot
add a missing typecheck while resolving model predicate (#1066)
323f532 
<!-- The PR description should answer 2 important questions: -->

### What

FIx a pending TODO; add a missing typecheck while resolving model
predicates.

This will check for the types of literal values in value expressions
used in various predicates.

### How

Use the `typecheck_value_expression` function to typecheck while
resolving model predicates as well.

V3_GIT_ORIGIN_REV_ID: 299aa432bc3ec98910441223eac8c8fc1a082aec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikvt26 @hasura-bot @shahidhk