Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error messages for duplicate migration versions (close #1148) #1157

Merged
merged 3 commits into from
Dec 4, 2018
Merged

better error messages for duplicate migration versions (close #1148) #1157

merged 3 commits into from
Dec 4, 2018

Conversation

arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Dec 3, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1148

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Dec 3, 2018
@hasura-bot
Copy link
Contributor

Review app for commit d1af285 deployed to Heroku: https://hge-ci-pull-1157.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1157-d1af285

@shahidhk shahidhk changed the title show better error messages if there are duplicate migration versions (close #1148) better error messages for duplicate migration versions (close #1148) Dec 4, 2018
@hasura-bot
Copy link
Contributor

Review app for commit 9fd760c deployed to Heroku: https://hge-ci-pull-1157.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1157-9fd760c

@shahidhk shahidhk merged commit 56dbc59 into hasura:master Dec 4, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1157.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the issue-1148 branch January 3, 2019 10:56
hasura-bot pushed a commit that referenced this pull request Sep 25, 2024
@rakeshkky @hasura-bot
graphql-ws: Use polling interval from opendd config (#1157)
531dc88 
<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->
Use polling interval from OpenDD metadata instead of hard-coded 2
seconds.

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

The interval value (in milliseconds) is already available in
subscription plan. Use it.

V3_GIT_ORIGIN_REV_ID: be99c3367b8d29b085fe536c26cd44ed601c7d91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees
No one assigned
Labels
c/cli Related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvi3411301 @hasura-bot @shahidhk