chore(package): use dist dir for publish and entrypoint #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steebchen
force-pushed
the
chore/package-dist
branch
from
019c470
to
9438960
Compare
Change the behaviour of the dist directory: - set dist/index.js as entrypoint - set `files` to only include the dist directory on publish This makes development easier because the entrypoint is the same when using npm/pnpm link. The only downside is that imports for the end user would include the dist directory, but everything should be imported from the root package anyway.
steebchen
force-pushed
the
chore/package-dist
branch
from
9438960
to
6583e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behaviour of the dist directory:
filesto only include the dist directory on publishThis makes development easier because the entrypoint is the same when using npm/pnpm link.
The only downside is that imports for the end user would include the dist directory (e.g.
@hatchet-dev/typescript-sdk/dist/foo/bar), but everything should be imported from the root package anyway.