-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix host rp2040 with low speed device #862
Conversation
fix host buf_sel panic with "already available"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i you meant to leave all the extra logging stuff in there?
note i'd like to pull this into the pico-0.10.0 branch anyway which we'll ship SDK1.2.0 with most likely |
no problem, I could release this as 0.10.1 , there is also issue when using pico reading msc thumbdrive as well. I will try to look at when I got time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me assuming @kilograham agrees the Low Speed DATA PID conversation is resolved.
The PID is toggled by hardware as captured in analyzer. without the fix, it will trigger the incorrect PID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok; "the code may be wrong, but fixes the problem at hand" :-) I'm cool with it for now!
The code is spot on afaik. Please provide example or hands on test case if you are still in doubt. PS: you guys could check this with hw ip team. I could only test its behavior from the sw point of view |
Describe the PR
Fix host rp2040 when mounting low speed device (e.g keyboard) with max packet size = 8
Fix #709, also replace raspberrypi/tinyusb#7 as the fix