Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#182 Remove support for institution name in menu items #185

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

moseshll
Copy link
Collaborator

@moseshll moseshll commented Jun 13, 2024

See issue #182. Some items in the menuitems table used to have an __INST__ placeholder so we could put an institution name, e.g., "All __INST__ Stats" expanding to "All Johns Hopkins Stats" for the now-defunct "institutional admin" class of user. This functionality is no longer used or needed.

The four commits, in order:

  • Add database fixtures to support adding a tests for the modified routine. They may not all be needed for the tests I wrote, but they will be at some point (as test coverage expands).
  • Modify CRMS::MenuItems to remove the __INST__ substitution.
  • Tidy CRMS::MenuItems
  • Fix for one of the aforementioned database fixtures which had a deprecated column removed as part a separate issue.

Reviewer: may want to run test procedure as spelled out in README. I am more interested in a check on the correctness and tidiness of CRMS::MenuItems which is a very small routine. I'm not happy about its return value (it should be an Object of some kind) but fixing that will be a separate issue to address later.

@moseshll moseshll marked this pull request as draft June 13, 2024 18:10
@moseshll moseshll marked this pull request as ready for review July 22, 2024 20:21
@moseshll moseshll requested a review from mwarin November 5, 2024 15:50
Copy link

@mwarin mwarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds & the tests pass. The logic changes are small and neat, and I don't really have anything to say about the DB inserts for testing.

Approve!

cgi/CRMS.pm Show resolved Hide resolved
@moseshll moseshll merged commit 3339de7 into main Nov 5, 2024
1 check passed
@moseshll moseshll deleted the 182_menu_item__INST__ branch November 5, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants