#182 Remove support for institution name in menu items #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #182. Some items in the
menuitems
table used to have an__INST__
placeholder so we could put an institution name, e.g., "All__INST__
Stats" expanding to "All Johns Hopkins Stats" for the now-defunct "institutional admin" class of user. This functionality is no longer used or needed.The four commits, in order:
CRMS::MenuItems
to remove the__INST__
substitution.CRMS::MenuItems
Reviewer: may want to run test procedure as spelled out in README. I am more interested in a check on the correctness and tidiness of
CRMS::MenuItems
which is a very small routine. I'm not happy about its return value (it should be an Object of some kind) but fixing that will be a separate issue to address later.