Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-1245 use rsync for deploying CRMS #188

Merged
merged 1 commit into from
Jul 11, 2024
Merged

DEV-1245 use rsync for deploying CRMS #188

merged 1 commit into from
Jul 11, 2024

Conversation

moseshll
Copy link
Collaborator

@moseshll moseshll commented Jul 3, 2024

This is pretty much boilerplate cribbed from the babel repo.

Reviewer: just a quick check to make sure I'm not forgetting anything. Staging credentials is handled by a script not currently under version control.

@moseshll moseshll requested a review from aelkiss July 10, 2024 18:42
@aelkiss
Copy link
Member

aelkiss commented Jul 10, 2024

Looks reasonable at first glance to me. I would recommend a couple things before cutting over:

  • temporarily add an echo in front of the rsync command so that it prints what it would run, but doesn't actually run it
  • use the -n flag with deploy-app to do a dry run & verify what would change
  • consider also using the --checksums flag with rsync (for testing) to verify what files are actually different (vs. what just has timestamp/ownership/permissions changes)

@moseshll moseshll merged commit a3673bd into main Jul 11, 2024
1 check passed
@moseshll moseshll deleted the DEV-1245_rsync branch July 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants