MarcXML parser for Exlibris Alma holdings output #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
reviewed
Feb 3, 2023
aelkiss
reviewed
Feb 21, 2023
mwarin
force-pushed
the
DEV-415-exlibris-sample
branch
from
75be46b
to
b2a8b36
Compare
mwarin
changed the title
mwarin
force-pushed
the
DEV-415-exlibris-sample
branch
from
71a321b
to
afd7c9c
Compare
Rebased & fixed. |
aelkiss
force-pushed
the
DEV-415-exlibris-sample
branch
from
161adb3
to
e578611
Compare
|
I handled some of the item type stuff so we can use the output more directly. On the file I have only 10 records appear to be govdocs with the given logic (out of 1,931,496 holdings records), so we'll definitely want to check that. |
|
Although I don't think we're doing anything with govdoc information right now anyway in holdings, so worst case maybe we can just omit that column. |
* to_s gave the field in addition to just the value * post-zephir processing also accepts "us " and "pr " as US location codes
|
I also fixed the govdoc parsing. @mwarin I figure before merging we should probably have some tests -- anything else you think we should do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this branch to work out how to deal with Exlibris's Alma MarcXML files.
See e.g. https://hathitrust.atlassian.net/browse/DEV-415, https://hathitrust.atlassian.net/browse/DEV-691 , https://hathitrust.atlassian.net/browse/DEV-692, but perhaps most of all DEV-833