Add External Tor Usage Documentation #1262

preland · 2024-09-08T23:25:24Z

This PR addresses #1253.

boldsuck · 2024-09-09T12:31:57Z

Hi @preland,
external Tor for Haveno Client can be used in 2 ways.

Your way with ControlPort: Haveno Client creates a hidden service with jtorctl. (You can not use HiddenServices options.)
Important: Haveno user must be in tor group to use ControlPort.
Add user to tor group on Debian/Ubuntu sudo usermod -aG debian-tor <user>.
Or how the seednodes, use the SocksPort. (Haveno user must not in tor group)
The HiddenService must be created in /etc/tor/torrc. (You can use all HiddenServices options.)
e.g.:

# Haveno incoming anonymity connections
HiddenServiceDir /var/lib/tor/haveno_service/
HiddenServicePort 9999 127.0.0.1:9999
HiddenServicePort 9999 [::1]:9999

With Haveno flags --hiddenServiceAddress=some.onion --nodePort=9999 or in haveno.properties.
#1170 (comment)

Maybe you can link to the seednode documentation ### Install Tor
https://github.com/haveno-dex/haveno/blob/master/docs/deployment-guide.md#install-tor
Install Tor from deb.torproject.org is preferred, Debian backports are also OK. Usually only a few days later. Both are from the same maintainer.

Prove if PoW is enabled: tor --list-modules
Tor config e.g. CookieAuthFile is preconfigured on Debian derivatives by /usr/share/tor/tor-service-defaults-torrc

woodser · 2024-09-13T16:34:08Z

docs/external-tor-usage.md

+
+### 1. Download and Install Tor
+#### Linux
+You can install Tor through your system's package manager, or directly by going to torproject.org. Note that your package manager's version of tor might be outdated or non-GNU (see below note).


Can you give an example using a common package manager? For example apt install ...

All of the issues mentioned should be addressed

woodser · 2024-09-13T16:35:05Z

docs/external-tor-usage.md

+#### Linux
+You can install Tor through your system's package manager, or directly by going to torproject.org. Note that your package manager's version of tor might be outdated or non-GNU (see below note).
+#### MacOS
+You can install Tor through Homebrew (brew install tor), or directly by going to torproject.org. Note that the Homebrew version of tor might be outdated or non-GNU (see note below).


Change to `brew install tor` with the backticks, so it's clear it's a command.

woodser · 2024-09-13T16:36:21Z

docs/external-tor-usage.md

+```
+> The "CookieAuthFile" path should be in a relatively stable and safe place. A good place to put it is in the same directory as torrc.
+
+### The location of your torrc file varies depending on your system:


Should be '####' so it's not at same level as main numbers?

These files do not exist by default after installing (at least on mac). Should they create it manually? Or start tor and stop tor to create the default file?

woodser · 2024-09-13T16:39:40Z

docs/external-tor-usage.md

+You can install Tor directly by going to torproject.org.
+> For best results, ensure that your version of tor matches the one currently used by Haveno. To improve loading times, it is highly recommended to use the GNU build, as it has support for POW. You can check if your build is GNU by running tor --version and looking for a response mentioning GNU.
+
+### 2. Add the following lines to your torrc:


Please change to "torcc file:" for clarity / consistency.

woodser · 2024-09-13T16:42:27Z

docs/external-tor-usage.md

+CookieAuthentication 1
+CookieAuthFile <path to cookie auth file>
+```
+> The "CookieAuthFile" path should be in a relatively stable and safe place. A good place to put it is in the same directory as torrc.


Maybe show an example path to use for CookieAuthFile?

Something like:

"For example, on Linux you could use CookieAuthFile /etc/tor/torrc"

woodser · 2024-09-13T16:47:00Z

docs/external-tor-usage.md

+#### Windows
+```\Browser\TorBrowser\Data\Tor\torrc``` (when using the Tor Browser Bundle)
+
+> The above locations are best guesses, and may be incorrect depending on your installation method or platform distribution. In the case that you cannot find the correct directory to place your torrc, tor can be ran in the following format to use a custom torrc: ```tor -f <torrc>```


Suggested tweaks:

"The above locations may vary depending on your installation method or platform distribution. If you cannot find the correct directory to place your torrc file, you can specify a custom path to torcc in the following format: tor -f <path to torcc>

woodser · 2024-09-13T16:48:10Z

docs/external-tor-usage.md

+## Using External Tor with Haveno:
+Run the Haveno binary with the following extra flags:
+```
+--torControlPort=9051 --torControlCookieFile=<path to cookie auth file> --torControlUseSafeCookieAuth=true


Just confirming, the user must repeat these definitions, both in the torcc file and when invoking the Haveno binary?

Yes; this tells Haveno to use the tor port and authentication for the external tor instead of the internal tor

woodser · 2024-09-13T16:48:43Z

docs/external-tor-usage.md

+```
+> Replace the ```<path to cookie auth file>``` with the location you specified in step 2.
+
+> Depending on how your version of Haveno was distributed, you may not have direct access to the haveno binary. In this case, you should look inside your Haveno distribution for the binary, and then run the binary using the above flags. For example, on MacOS the binary will be located within the app at Haveno.app/Contents/MacOS/Haveno, or something similar.


"haveno" should be capitalized for consistency.

woodser · 2024-09-18T15:31:25Z

I can't get tor to create my cookie authentication file for some reason. Not sure what I'm doing wrong, but it's not created when tor is started. I've configured my torrc file (installed through homebrew):

ControlPort 9051
CookieAuthentication 1
CookieAuthFile /opt/homebrew/etc/tor/control_auth_cookie

Tor has permission to write to that directory.

add external tor usage documentation

07883fb

preland requested a review from a team as a code owner September 8, 2024 23:25

preland added 2 commits September 9, 2024 10:55

Merge branch 'haveno-dex:master' into issue1253

5bb55ee

Update external-tor-usage.md

d2acf6a

woodser reviewed Sep 13, 2024

View reviewed changes

preland added 2 commits September 13, 2024 13:51

Update external-tor-usage.md

b1de3d2

Merge branch 'haveno-dex:master' into issue1253

724bccb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add External Tor Usage Documentation #1262

Add External Tor Usage Documentation #1262

preland commented Sep 8, 2024

boldsuck commented Sep 9, 2024 •

edited

Loading

woodser Sep 13, 2024 •

edited

Loading

preland Sep 13, 2024

woodser Sep 13, 2024

woodser Sep 13, 2024

woodser Sep 13, 2024

woodser Sep 13, 2024

woodser Sep 13, 2024

woodser Sep 13, 2024 •

edited

Loading

woodser Sep 13, 2024

preland Sep 13, 2024

woodser Sep 13, 2024

woodser commented Sep 18, 2024

Add External Tor Usage Documentation #1262

Are you sure you want to change the base?

Add External Tor Usage Documentation #1262

Conversation

preland commented Sep 8, 2024

boldsuck commented Sep 9, 2024 • edited Loading

woodser Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woodser Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

woodser commented Sep 18, 2024

boldsuck commented Sep 9, 2024 •

edited

Loading

woodser Sep 13, 2024 •

edited

Loading

woodser Sep 13, 2024 •

edited

Loading