Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios)!: extract FCM related logic to PushPluginFCM #293

Merged
merged 14 commits into from
Oct 16, 2024

Conversation

erisu
Copy link

@erisu erisu commented Sep 18, 2024

Description

Closes #285

This PR would replace #285. This PR does not upgrade to 10.24.0 as #285 does but a separate PR would handle the version upgrade.

Extracts all FCM related logic to its own class.

Related Issue

Motivation and Context

Improve separation, maintainability, & encapsulation between FCM and non FCM code.

How Has This Been Tested?

  • Build
  • Run on Simulator
    • Drop APNs payloads
  • Run on Device
    • Pushed notification through FCM console

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu force-pushed the feat/ios-extract-firebase branch 2 times, most recently from 6c03f00 to 982157e Compare October 16, 2024 04:50
Base automatically changed from feat/extract-ios-settings to master October 16, 2024 04:55
@erisu erisu marked this pull request as ready for review October 16, 2024 04:58
@erisu erisu force-pushed the feat/ios-extract-firebase branch 3 times, most recently from 5e06c28 to 8a8e2a4 Compare October 16, 2024 07:22
@erisu erisu merged commit 1323ec8 into master Oct 16, 2024
6 checks passed
@erisu erisu deleted the feat/ios-extract-firebase branch October 16, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant