forked from phonegap/phonegap-plugin-push
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios)!: extract FCM related logic to PushPluginFCM #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
force-pushed
the
feat/ios-extract-firebase
branch
2 times, most recently
from
October 16, 2024 04:50
6c03f00
to
982157e
Compare
…etting APNS token
erisu
force-pushed
the
feat/ios-extract-firebase
branch
from
October 16, 2024 04:56
982157e
to
413e693
Compare
erisu
force-pushed
the
feat/ios-extract-firebase
branch
3 times, most recently
from
October 16, 2024 07:22
5e06c28
to
8a8e2a4
Compare
erisu
force-pushed
the
feat/ios-extract-firebase
branch
from
October 16, 2024 11:15
d88c027
to
8c054ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #285
This PR would replace #285. This PR does not upgrade to 10.24.0 as #285 does but a separate PR would handle the version upgrade.
Extracts all FCM related logic to its own class.
Related Issue
Motivation and Context
Improve separation, maintainability, & encapsulation between FCM and non FCM code.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: