Lazy load endpoints. #188
Merged
Lazy load endpoints. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfcosta
approved these changes
Feb 24, 2017
| @@ -47,13 +31,37 @@ def method_missing(name, *args, &block) | |||
| delegate_client.__send__(method, *args, &block) | |||
| end | |||
|
|
|||
| def inventory | |||
| @inventory ||= Inventory::InventoryClient.create(entrypoint: "#{@state[:entrypoint]}/hawkular/inventory", | |||
There was a problem hiding this comment.
Why does Metrics has a different class name? Can we change the others to be like it? I like it better than to have Inventory::Inventory and Alerts::Alerts.
There was a problem hiding this comment.
Also the initialization is different on Inventory but not on the others.
There was a problem hiding this comment.
I'm not sure, but at this point i don't want to break stuff like this: https://github.com/ManageIQ/manageiq/pull/13814/files#diff-7873cbd67d037fe54151ac4d277ccdd4R44
There was a problem hiding this comment.
You can have this at the end of the file and keep it compatible:
Inventory::InventoryClient = Inventory::ClientThere was a problem hiding this comment.
Will open a separate PR to uniform it.
josejulio
force-pushed
the
lazy_load_endpoints
branch
from
dd34ed3
to
4a2e14c
Compare
|
@rubenvp8510 could you please merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading the endpoints. This will keep our users for having to do stuff like ManageIQ/manageiq#13814
@cfcosta could you please review ?
// cc @pilhuhn