start on SMP bringup #347
Merged
start on SMP bringup #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the `AcpiHandler` glue trait from the `acpi` crate to allow using `acpi` in the kernel. This trait is responsible for mapping physical memory regions that contain ACPI tables. In this case, we know these memory regions are identity mapped, so we don't actually have to map and unmap pages in order to implement this trait. Instead, we just have to calculate the virtual address based on the kernel's virtual memory offset and tell the `acpi` crate to use that region.
hawkw
added a commit
that referenced
this pull request
Oct 14, 2022
The `x86_64.rs` file has just kind of been a dumping ground for random arch stuff for a while. This commit pulls out the `bootloader` crate glue code and the tests into separate files.
hawkw
added a commit
that referenced
this pull request
Oct 14, 2022
This commit starts on #345 by using the `acpi` crate to read information from the ACPI tables related to SMP. It adds an `acpi::bringup_smp` function in `arch::x86_64`, but this function doesn't *currently* actually bring up application processors. Instead, it just reads data from the ACPI tables and logs it as a way to check that we are, in fact, able to find the information we need. Additionally, I added a new `ArchInfo` struct that contains opaque architecture-specific data from the bootloader's boot info. This is passed into the `kernel_start` function, but the cross-platform kernel code doesn't consume it --- instead, it's just provided so it can be passed back into `arch_init` once we've done cross-platform setup stuff. This felt better than sticking the RSDP addr in a global variable or something... This is a first step towards #345. Future commits will actually switch to IOAPIC interrupt handling and then start the application processors.
hawkw
force-pushed
the
eliza/smp-bringup
branch
from
a5a86ef
to
adf7d27
Compare
The `x86_64.rs` file has just kind of been a dumping ground for random arch stuff for a while. This commit pulls out the `bootloader` crate glue code and the tests into separate files.
This commit starts on #345 by using the `acpi` crate to read information from the ACPI tables related to SMP. It adds an `acpi::bringup_smp` function in `arch::x86_64`, but this function doesn't *currently* actually bring up application processors. Instead, it just reads data from the ACPI tables and logs it as a way to check that we are, in fact, able to find the information we need. Additionally, I added a new `ArchInfo` struct that contains opaque architecture-specific data from the bootloader's boot info. This is passed into the `kernel_start` function, but the cross-platform kernel code doesn't consume it --- instead, it's just provided so it can be passed back into `arch_init` once we've done cross-platform setup stuff. This felt better than sticking the RSDP addr in a global variable or something... This is a first step towards #345. Future commits will actually switch to IOAPIC interrupt handling and then start the application processors.
hawkw
force-pushed
the
eliza/smp-bringup
branch
from
adf7d27
to
cab7e50
Compare
hawkw
added a commit
that referenced
this pull request
Oct 14, 2022
The `x86_64.rs` file has just kind of been a dumping ground for random arch stuff for a while. This commit pulls out the `bootloader` crate glue code and the tests into separate files.
hawkw
added a commit
that referenced
this pull request
Oct 14, 2022
This commit starts on #345 by using the `acpi` crate to read information from the ACPI tables related to SMP. It adds an `acpi::bringup_smp` function in `arch::x86_64`, but this function doesn't *currently* actually bring up application processors. Instead, it just reads data from the ACPI tables and logs it as a way to check that we are, in fact, able to find the information we need. Additionally, I added a new `ArchInfo` struct that contains opaque architecture-specific data from the bootloader's boot info. This is passed into the `kernel_start` function, but the cross-platform kernel code doesn't consume it --- instead, it's just provided so it can be passed back into `arch_init` once we've done cross-platform setup stuff. This felt better than sticking the RSDP addr in a global variable or something... This is a first step towards #345. Future commits will actually switch to IOAPIC interrupt handling and then start the application processors.
hawkw
added a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.