-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maitake_sync: add a bunch of new APIs to locks #473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `into_inner` methods to the `Mutex`, `RwLock`, `spin::RwLock`, and `spin::Mutex` types, allowing the inner value to be extracted from the lock when the lock is owned exclusively. This seemed like a nice thing to add.
This commit adds `get_mut` methods to `Mutex`, `RwLock`, `spin::Mutex`, and `spin::RwLock`, allowing mutable access without locking when the lock itself can be accessed mutably. These are identical to the `std::sync::Mutex::get_mut` and `std::sync::RwLock::get_mut` methods.
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex` where `T: Default`, allowing locked data to be constructed through `Default` without needing `Mutex::new(Default::default())` or similar. An implementation of `Default` for `spin::RwLock` was not added, because I already did that in #472.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This commit adds `into_inner` methods to the `Mutex`, `RwLock`, `spin::RwLock`, and `spin::Mutex` types, allowing the inner value to be extracted from the lock when the lock is owned exclusively. This seemed like a nice thing to add.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This commit adds `get_mut` methods to `Mutex`, `RwLock`, `spin::Mutex`, and `spin::RwLock`, allowing mutable access without locking when the lock itself can be accessed mutably. These are identical to the `std::sync::Mutex::get_mut` and `std::sync::RwLock::get_mut` methods.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex` where `T: Default`, allowing locked data to be constructed through `Default` without needing `Mutex::new(Default::default())` or similar. An implementation of `Default` for `spin::RwLock` was not added, because I already did that in #472.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.