Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maitake_sync: add a bunch of new APIs to locks #473

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Conversation

hawkw
Copy link
Owner

@hawkw hawkw commented Jan 27, 2024

No description provided.

This commit adds `into_inner` methods to the `Mutex`, `RwLock`,
`spin::RwLock`, and `spin::Mutex` types, allowing the inner value to be
extracted from the lock when the lock is owned exclusively. This seemed
like a nice thing to add.
This commit adds `get_mut` methods to `Mutex`, `RwLock`, `spin::Mutex`,
and `spin::RwLock`, allowing mutable access without locking when the
lock itself can be accessed mutably. These are identical to the
`std::sync::Mutex::get_mut` and `std::sync::RwLock::get_mut` methods.
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex`
where `T: Default`, allowing locked data to be constructed through
`Default` without needing `Mutex::new(Default::default())` or similar.

An implementation of `Default` for `spin::RwLock` was not added, because
I already did that in #472.
)

This commit adds two new methods to `spin::RwLock`:

- `reader_count` returns the current number of read locks held.
- `has_writer` returns true if a write lock is currently held.
@hawkw hawkw enabled auto-merge (rebase) January 27, 2024 20:57
@hawkw hawkw merged commit dba0827 into main Jan 27, 2024
17 checks passed
@hawkw hawkw deleted the eliza/lock-utils branch January 27, 2024 21:02
hawkw added a commit that referenced this pull request Jan 27, 2024
This commit adds `into_inner` methods to the `Mutex`, `RwLock`,
`spin::RwLock`, and `spin::Mutex` types, allowing the inner value to be
extracted from the lock when the lock is owned exclusively. This seemed
like a nice thing to add.
hawkw added a commit that referenced this pull request Jan 27, 2024
This commit adds `get_mut` methods to `Mutex`, `RwLock`, `spin::Mutex`,
and `spin::RwLock`, allowing mutable access without locking when the
lock itself can be accessed mutably. These are identical to the
`std::sync::Mutex::get_mut` and `std::sync::RwLock::get_mut` methods.
hawkw added a commit that referenced this pull request Jan 27, 2024
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex`
where `T: Default`, allowing locked data to be constructed through
`Default` without needing `Mutex::new(Default::default())` or similar.

An implementation of `Default` for `spin::RwLock` was not added, because
I already did that in #472.
hawkw added a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant