Remove master profile and replace with property override #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enozcan
reviewed
Dec 14, 2020
@enozcan @pivovarit actually, we do not need |
|
To be honest, I did not even realize the existence of the master profile, but I question the need for it since you can achieve the same by just swapping the dependency version without hardcoding anything into the code itself. So, I just fixed a broken pipeline definition but the next stage would be to remove the master profile |
pivovarit
changed the title
hasancelik
approved these changes
Dec 14, 2020
enozcan
approved these changes
Dec 14, 2020
hasancelik
approved these changes
Dec 14, 2020
|
@enozcan I killed them long time ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.