Fix for decompiled calls to native Linq Api #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 2, 2019 13:38
…ork with branches during local tests
Force DecompilerTestBase to visit decompiled expressions
Extended ExpressionHelper.Default to handle explicit default value
magicmoux
commented
Jul 24, 2019
src/DelegateDecompiler/Processor.cs
Outdated
| var expectedParameters = m.GetParameters(); | ||
| object[] convertedArguments = new object[expectedParameters.Length]; | ||
| //TODO work a way to resolve non expression parameters into the expected type without resorting to a switch on the methodname if possible | ||
| for (int i = 0; i < expectedParameters.Count(); i++) |
There was a problem hiding this comment.
This is the really dirty part (lines 1133..1155) but it seems to be exhautive until now
magicmoux
commented
Jul 24, 2019
src/DelegateDecompiler/Processor.cs
Outdated
| @@ -1207,6 +1282,25 @@ static Expression BuildMethodCallExpression(MethodInfo m, Address instance, Expr | |||
| return Expression.NewArrayInit(arguments[0].Type.GetElementType(), initializers); | |||
| } | |||
|
|
|||
| #region Nested Lambdas decompilation | |||
There was a problem hiding this comment.
this region should better be name reflection decompilation
magicmoux
commented
Jul 24, 2019
src/DelegateDecompiler/Processor.cs
Outdated
| var rightExpression = rightState.Stack.Pop(); | ||
| var leftExpression = leftState.Stack.Pop(); | ||
| buffer.Add(Address.Merge(test, leftExpression, rightExpression, addressMap)); | ||
| var rightExpression = rightState.Stack.Count > 0 ? rightState.Stack.Pop() : null; |
There was a problem hiding this comment.
minor optimization
Added a special handling for backing fields to avoid annoying Linq2Entities exceptions on uncompletedly defined Computed Properties across type hierarchies:
For proof example, if you code this
```
public class LivingBeeing
{
` public virtual string Species { get; }
[...]
}
```
Related tests will fail
|
Hi @hazzik, could you take a look at this PR please ? |
added 5 commits
December 4, 2019 13:35
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hazzik,
I've been testing DD for awhile in some side-project and I've encountered a case where the decompilation processor returns call-instructions to the Native Linq API, like
If I'm not mistaken, these calls can be translated into lambdas and/or, let's say can at least be directly interpreted , here is a Processor.cs implementation to handle such cases.
Could you please take a look on it and tell me whether the solution is acceptable ?
Sorry, I'm not yet able to provide unit tests about those cases (in fact, my side-project follows a similar approach to the late KnockoutMVC you mentioned in #122 .)
Max.