-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix computed abstract property decompilation #180
Fix computed abstract property decompilation #180
Conversation
Fix abstract computed property decompilation in case of there is an intermediate generic abstract class
Hi, this just hides the symptoms unfortunately. You can check that by adding another property to |
Hi, not quite sure that I follow what you mean by "hides the symptoms". Do you mean that if there is intermediate implmentation of |
Yes. If Fish<>.Species has an implementation whole thing fails. |
@DennisInSky please check if that solution works for you. |
Hi @hazzik thank you very much for the commits. There are a couple of things to mention:
To be more precise it works till the moment a condition applied to it. |
Fixed, thanks.
The expression generated is correct. It does not work, because you've skipped |
Thanks, it looks good now.
I thought that it might not be always the case when the entire CLR hierarchy mapped to EF hierarchy. Thank you very much for your effort for fixing the issue. Any plans to release a version with this fix? |
@DennisInSky can you try if it works in your case? If so I'll merge and release ASAP. |
Hi @hazzik . I checked my case with the new code wired up and everything worked out as a charm. Thanks once again. |
Cool thanks for confirming. |
Released in 0.30.0 |
Fixes hazzik#179 Co-authored-by: Alex Zaytsev <[email protected]> +semver:feature
Fix comuted abstract property decompilation in case of there is an intermediate generic abstract class
Fixes #179