Fix issue with unbound Parameters #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 it is either |
hazzik
changed the title
|
This has been released in |
billybraga
pushed a commit
to billybraga/DelegateDecompiler
that referenced
this pull request
Nov 3, 2023
+semver:feature Co-authored-by: Alex Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hazzik Alex,
PR #190 seems to solve nicely the changes I proposed in Processor.cs from #185
The implementation however raises a runtime issue when executing the query against a provider (unit test is /src/DelegateDecompiler.EntityFramework.Tests/TestGroup90AdditionalFeatures/Test01Issue152.cs).
The problem seems to be caused by the invocation of the compiled expression (OptimizeExpressionVisitor.cs#L455)
In the output Quoted lambda, ParameterExpressions instances in the body are not references to the Quoted Lambda corresponding Parameter.