Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewed up to exploration of results #82

Merged
merged 24 commits into from
Sep 6, 2022
Merged

Conversation

Amelie-TGHN
Copy link
Contributor

Note: The link to the source dataset is broken.
Questions: Any specific reason to start from sce object rather than seurat object? (assuming this is what was available from the authors)

Note: The link to the source dataset is broken.
Questions: Is this dataset still the one used for the main scRNA-seq lecture? Any specific reason to start from sce object rather than seurat object?
Suggested simplification of "count aggregation" code; Added comments for clarification and images (still need to upload). 
Swapped "counts aggregation" and "handling metadata" sections (to enable generating more "custom" metadata per cell type, including a covariate with cell count per sample for this cell type instead of overall, and to handle the case where one sample may have zero cells for that cell type)
Added sub-headers to data wrangling sections. Replaced used of grep() (which I usually use in my own studies but fails in that case since some cell type names contain the character "+")
Used list and loop to create metadata for each cell type, matching list of counts matrices generated before. Code should work for case when one sample has zero cell for one given cell type.
PCA plot looks quite different (same global clustering pattern and conclusion, but spread within sample group not the same). Assuming this is a R/DESeq2 version effect, but will double-check previous steps in my updated code...
Assuming you didn't want to enter into this level of detail, but why not run paired analyses here, since we have one stim and one control for each patient (i.e. adding patient_id in the design formula?)
@Amelie-TGHN Amelie-TGHN changed the title reviewed intro and dataset description reviewed up to exploration of results Aug 22, 2022
@Amelie-TGHN Amelie-TGHN marked this pull request as ready for review August 22, 2022 20:08
@mistrm82 mistrm82 merged commit 5a1476f into master Sep 6, 2022
@mistrm82
Copy link
Contributor

mistrm82 commented Sep 6, 2022

Thanks @Amelie-TGHN !!

@mistrm82 mistrm82 deleted the Amelie-TGHN-2022-08-update branch September 26, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants