Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding problems on macOS #1966

Open
markusstoll opened this issue Feb 12, 2021 · 2 comments
Open

Encoding problems on macOS #1966

markusstoll opened this issue Feb 12, 2021 · 2 comments

Comments

@markusstoll
Copy link
Contributor

When compiling with a fresh VisualStudio installation on macOS BigSur it turns out, the default encoding is set to ASCII which is causing some problems with your current encoding handling.
Especially the path conversions for the changes view do make things worse.
Before trying to build a pull request - for which runtime is this actually needed?
@markusstoll
Copy link
Contributor Author

Did some research - this handling was introduced for the Windows version. I will create a PR where my fix will only affect the macOS version and leave the Windows version untouched

@markusstoll markusstoll mentioned this issue Feb 15, 2021
Merged
@markusstoll
Copy link
Contributor Author

I guess this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markusstoll