Bugfixes/mac fix encodingproblems #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings on git command things are already and would get worse if default encoding is ASCII (which seems to be the case for current VisualStudio 2019)
hbons
reviewed
Feb 15, 2021
| { | ||
| } | ||
|
|
||
| public EventLogController (bool fix_utf_encoding) |
There was a problem hiding this comment.
From where do you ever call this constructor with fix_utf_encodning = - false?
There was a problem hiding this comment.
from SparkleShare/Mac/UserInterface/EventLog.cs
As with current VisualStudio for Mac 2019 the default encoding is ASCII (don't ask me why)- this conversion needs to be switched off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1966
With current Visual Studio the complete handling of special characters in path/file names was broken.
This fix enforces UTF8 encoding for all git calls and disables the encoding conversion which break things again as Default encoding is ASCII on current Visual Studio 2019 on macOS