Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rpb-spatial from CSV/XLS file in RPB-173 #223

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Jul 2, 2024

@fsteeg fsteeg requested a review from acka47 July 2, 2024 13:29
fsteeg added a commit to hbz/rpb that referenced this pull request Jul 2, 2024
@fsteeg
Copy link
Member Author

fsteeg commented Jul 3, 2024

Hm, build fails when including entries not used in RPB due to missing broader concepts, e.g. n140060680102 has broader n14006068, which is not in the SKOS. I think this is caused by errors in the original CSV/XLS, will investigate.

@fsteeg fsteeg assigned fsteeg and unassigned acka47 Jul 3, 2024
@fsteeg
Copy link
Member Author

fsteeg commented Jul 4, 2024

With fixed IDs the build now works, but the page doesn't look right:

https://skohub.io/hbz/lobid-vocabs/heads/rpb-173-updateRpbSpatial/rpb.lobid.org/spatial.html

"No label for language "" provided", and can't expand the items.

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jul 4, 2024
@acka47
Copy link
Contributor

acka47 commented Jul 5, 2024

This is a problem with SkoHub Vocabs, I assume in combination with vocabularies that use hash URIs. it works for me when:

@fsteeg
Copy link
Member Author

fsteeg commented Jul 5, 2024

sometimes I have to click several times resp. wait a while until the page is served

Hm, for me, it only comes up when I open in a new tab, but then again ""No label for language "" provided"". Could this be related to my system locale being set to en? I tried adding de to my browser languages, I see that I'm sending Accept-Language: de,en..., but still the same, and the overview page remains English.

@fsteeg
Copy link
Member Author

fsteeg commented Jul 5, 2024

Oh, now I go it it working (clicked in overview, then Reload/F5 did the trick for me).

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 assigned fsteeg and unassigned acka47 Jul 10, 2024
@acka47 acka47 merged commit 195f1be into master Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants