Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volta project setup #3683

Closed
wants to merge 2 commits into from
Closed

Volta project setup #3683

wants to merge 2 commits into from

Conversation

nsklyarov
Copy link

Contribution checklist

Brief description

This Pull Request updates Node.js version management from NVM to Volta for a more straightforward and dependable setup.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I've was added global package.json, it caused cache issues within rush build's, not sure it is a good idea to add it.

Copy link
Author

@nsklyarov nsklyarov Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. I didn’t find any other way to pin the version of node in a project using Volta other than package.json.
But I have found issue about this.

@haiodo
Copy link
Member

haiodo commented Sep 12, 2023

Probable a good idea will be just to have a list of possible node managers and required version of node, platform actually are not strongly depend on particular node version, it could work fine with node starting v14, the one we started with.

@aonnikov
Copy link
Member

Probable a good idea will be just to have a list of possible node managers and required version of node, platform actually are not strongly depend on particular node version, it could work fine with node starting v14, the one we started with.

Actually I saw a problem in some pod project with node < v18, but don't remember the details already 😄

@haiodo haiodo closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants