Switch to a maintained fork of the kubectl provider #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mpepping
commented
Aug 7, 2024
mpepping
commented
- The alekc/kubectl provider is a maintained fork of gavinbunney/kubectl
- The alekc/kubectl provider is trusted by both terraform and opentofu
Commitlint-CheckThanks for your contribution ❤️ Unfortunately, commitlint has detected that this PR has one ore more commit messages that do not follow the conventional commit format 🙀 Please update the commit messages accordingly. |
mpepping
force-pushed
the
provider-kubectl
branch
from
c42699c
to
5b509ee
Compare
Terraform-Check (version: 1.8.5): ✅🖌 Terraform Format: ✅⚙️ Terraform Init: ✅🤖 Terraform Validate: ✅ |
Terraform-Check (version: 1.9.4): ✅🖌 Terraform Format: ✅⚙️ Terraform Init: ✅🤖 Terraform Validate: ✅ |
|
When i started developing the module, I had to choose between these two providers and decided against the alekc version. 147 stars and a single maintaining person is simply not enough trust for me. What do you mean by "The alekc/kubectl provider is trusted by both terraform and opentofu"? Anyway, it currently works with givebunny and unless there's a really good reason, I don't think it's necessary to switch. |
|
@mrclrchtr, thnx for looking in to this. The This makes a tofu throw a warning when doing an init on TF code that uses hcloud-talos: ❯ tofu init -upgrade
[..]
- Installing gavinbunney/kubectl v1.14.0...
- Installed gavinbunney/kubectl v1.14.0. Signature validation was skipped due to the registry not containing GPG keys for this providerSo this isn't an issue for Terraform, since the public key for gavinbunney/kubectl is added to registry.terraform.io. But it does throw a warning when using OpenTofu. See this GitHub issue for some more context: gavinbunney/terraform-provider-kubectl#294 |
|
I see. Unfortunately I can't test right now due to lack of time. Does everything work exactly the same as before? |
Terraform-Check (version: 1.9.5): ✅🖌 Terraform Format: ✅⚙️ Terraform Init: ✅🤖 Terraform Validate: ✅ |
Backwards compatible and tested. |
|
Ok, thank you. I am ready to merge the branch. But currently this is not possible, because of the merge commits I think... not sure why.
Could you rebase the branch again instead of doing merge commits? |
mpepping
force-pushed
the
provider-kubectl
branch
from
456828a
to
81b7150
Compare
mrclrchtr
force-pushed
the
main
branch
4 times, most recently
from
fb8d2a3
to
09d919a
Compare
* The gavinbunney/kubectl is not being maintained * The alekc/kubectl provider is a maintained fork * The alekc/kubectl provider is trusted by both terraform and opentofu
mrclrchtr
force-pushed
the
provider-kubectl
branch
from
81b7150
to
83bb7d6
Compare
Terraform-Check (version: 1.9.6): ✅🖌 Terraform Format: ✅⚙️ Terraform Init: ✅🤖 Terraform Validate: ✅ |
|
🎉 This PR is included in version 2.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.