Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox.ini to use test_gallery.py and fix gallery-python-3.7 tests #52

Closed
mavaylon1 opened this issue Dec 22, 2022 · 3 comments
Closed

Update tox.ini to use test_gallery.py and fix gallery-python-3.7 tests #52

mavaylon1 opened this issue Dec 22, 2022 · 3 comments
Assignees
@mavaylon1
Labels
category: bug errors in the code or code behavior category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@mavaylon1
Copy link
Contributor

  1. Update tox.ini to use test_gallery.py to be in line with HDMF
  2. Currently both linux-gallery-python3.7-minimum and windows-gallery-python3.7-minimum will pass locally when running "python test.py --example", but not during the github checks. I've also tested a version of test_gallery.py by running in a branch "python test_gallery.py"; however, this returns an error regarding missing files. (Refer to attached images)
    Screen Shot 2022-12-21 at 11 01 36 AM
@mavaylon1 mavaylon1 added category: bug errors in the code or code behavior category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users labels Dec 22, 2022
@mavaylon1 mavaylon1 self-assigned this Dec 22, 2022
@mavaylon1
Copy link
Contributor Author

@rly I'd love some help with this. I've tested all my ideas of checking if the the files are indeed found in the directory by printing out the list of files used in test_gallery.py, and fiddling with absolute paths.

@mavaylon1 mavaylon1 mentioned this issue Dec 22, 2022
Merged
@rly
Copy link
Contributor

rly commented Dec 22, 2022

I'll take a look

@rly rly closed this as completed Jan 5, 2023
@rly
Copy link
Contributor

rly commented Jan 5, 2023

Closed with #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavaylon1 mavaylon1

Labels
category: bug errors in the code or code behavior category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rly @mavaylon1