-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NWB file convert unit test #161
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #161 +/- ##
==========================================
+ Coverage 85.59% 86.04% +0.45%
==========================================
Files 5 5
Lines 1159 1161 +2
Branches 295 296 +1
==========================================
+ Hits 992 999 +7
+ Misses 110 107 -3
+ Partials 57 55 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oruebel that solved my issue!
Do you think you oculd cut a 0.5.1 release with this fix?
Let me see what I can do. From a code perspective, I don't think there is anything in the way of making a release. I haven't done a release myself in a while, so let me see what I can do. |
Thanks! If that's not possible we'll pin our pipeline to the commit, but it would be great to pin a release version :) |
I'll see if I can cut release today and get back to you |
Motivation
Fix [Bug]: ValueError when using
export
function (forsubject.date_of_birth
) #160Updated
ZarrIO.get_type
to resolvebytes
dtypeAdd test mixin to test rountrip conversion for a minimal NWB file
Updated
How to test the behavior?
Checklist
ruff
from the source directory.