Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NWB file convert unit test #161

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Add NWB file convert unit test #161

merged 3 commits into from
Feb 13, 2024

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 12, 2024

Motivation

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel marked this pull request as ready for review February 13, 2024 00:46
@oruebel oruebel added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Feb 13, 2024
@oruebel oruebel added this to the Next Release milestone Feb 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (300070b) 85.59% compared to head (9b2d2c9) 86.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #161      +/-   ##
==========================================
+ Coverage   85.59%   86.04%   +0.45%     
==========================================
  Files           5        5              
  Lines        1159     1161       +2     
  Branches      295      296       +1     
==========================================
+ Hits          992      999       +7     
+ Misses        110      107       -3     
+ Partials       57       55       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alejoe91 alejoe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oruebel that solved my issue!

Do you think you oculd cut a 0.5.1 release with this fix?

@oruebel
Copy link
Contributor Author

oruebel commented Feb 13, 2024

Do you think you oculd cut a 0.5.1 release with this fix?

Let me see what I can do. From a code perspective, I don't think there is anything in the way of making a release. I haven't done a release myself in a while, so let me see what I can do.

@oruebel oruebel merged commit f180b44 into dev Feb 13, 2024
24 checks passed
@oruebel oruebel deleted the exp/subject_bug branch February 13, 2024 17:56
@alejoe91
Copy link
Collaborator

Do you think you oculd cut a 0.5.1 release with this fix?

Let me see what I can do. From a code perspective, I don't think there is anything in the way of making a release. I haven't done a release myself in a while, so let me see what I can do.

Thanks! If that's not possible we'll pin our pipeline to the commit, but it would be great to pin a release version :)

@oruebel
Copy link
Contributor Author

oruebel commented Feb 13, 2024

I'll see if I can cut release today and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError when using export function (for subject.date_of_birth)
3 participants