Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for storage mapping #48

Merged
merged 7 commits into from
Dec 22, 2022
Merged

Add docs for storage mapping #48

merged 7 commits into from
Dec 22, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Dec 15, 2022

This PR adds docs similar to https://nwb-storage.readthedocs.io/en/latest/storage_hdf5.html to describe how elements of the HDMF specification language are mapped to storage in Zarr. This document also describes the implementation of links and object references on the storage side, since links and references are not natively supported by Zarr.

@oruebel
Copy link
Contributor Author

oruebel commented Dec 15, 2022

@alejoe91 this PR may also be of interest for you if you would like to better understand how hdmf-zarr maps NWB types to storage.

docs/source/storage.rst Outdated Show resolved Hide resolved
docs/source/storage.rst Outdated Show resolved Hide resolved
@alejoe91
Copy link
Collaborator

@alejoe91 this PR may also be of interest for you if you would like to better understand how hdmf-zarr maps NWB types to storage.

Thank you @oruebel

Will test this first thing next week!

oruebel and others added 2 commits December 16, 2022 14:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Base: 82.15% // Head: 82.15% // No change to project coverage 👍

Coverage data is based on head (4e37357) compared to base (5d2811d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #48   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files           9        9           
  Lines        2365     2365           
=======================================
  Hits         1943     1943           
  Misses        422      422           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oruebel
Copy link
Contributor Author

oruebel commented Dec 21, 2022

@mavaylon1 can you review this PR. This PR only adds documentation but it would be nice to merge it before the release.

@oruebel oruebel merged commit 6841196 into dev Dec 22, 2022
@oruebel oruebel deleted the add/storage_docs branch December 22, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants