Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add can_read classmethod to ZarrIO #97

Merged
merged 4 commits into from
Jun 18, 2023
Merged

add can_read classmethod to ZarrIO #97

merged 4 commits into from
Jun 18, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Jun 17, 2023

add test for new method

Motivation

NeurodataWithoutBorders/pynwb#859 (comment)

How to test the behavior?

ZarrIO.can_read(path)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

add test for new method
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (3c2bb12) 81.94% compared to head (26cad63) 82.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #97      +/-   ##
==========================================
+ Coverage   81.94%   82.00%   +0.06%     
==========================================
  Files          11       11              
  Lines        2647     2657      +10     
==========================================
+ Hits         2169     2179      +10     
  Misses        478      478              
Impacted Files Coverage Δ
src/hdmf_zarr/backend.py 87.87% <100.00%> (+0.12%) ⬆️
tests/unit/base_tests_zarrio.py 98.74% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bendichter bendichter merged commit 531296c into dev Jun 18, 2023
@bendichter bendichter deleted the can_read branch June 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants