Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape attribute on base classes of DynamicTableRegion #201

Closed
5 tasks done
oruebel opened this issue Nov 18, 2019 · 0 comments · Fixed by #202
Closed
5 tasks done

Add shape attribute on base classes of DynamicTableRegion #201

oruebel opened this issue Nov 18, 2019 · 0 comments · Fixed by #202
Assignees
Labels
category: enhancement improvements of code or code behavior help wanted: good first issue request for community contributions that are good for new contributors

Comments

@oruebel
Copy link
Contributor

oruebel commented Nov 18, 2019

In #191 we added the shape property to DynamicTableRegion For consistency we should add the shape property to the parent classes as well. This should require only adding shape to container.Data. This should also make shape validation on these objects more efficient.

Checklist

  • Have you ensured the feature or change was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
  • Have you checked our Contributing document?
@oruebel oruebel added category: enhancement improvements of code or code behavior help wanted: good first issue request for community contributions that are good for new contributors labels Nov 18, 2019
@oruebel oruebel self-assigned this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior help wanted: good first issue request for community contributions that are good for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant