Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with resolving attribute specs with same name #1122

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 2, 2024

Motivation

Fix #1121

How to test the behavior?

See new tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 64.06250% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (9387e85) to head (f139d0c).
Report is 31 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/spec/spec.py 64.06% 14 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1122      +/-   ##
==========================================
- Coverage   88.86%   88.79%   -0.08%     
==========================================
  Files          45       45              
  Lines        9774     9774              
  Branches     2776     2776              
==========================================
- Hits         8686     8679       -7     
- Misses        774      778       +4     
- Partials      314      317       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly merged commit 2505a0e into dev Jun 5, 2024
29 checks passed
@rly rly deleted the fix/resolve_attribute_spec branch June 5, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resolving spec inheritance fails when attribute has same name as existing attr on another object
2 participants