-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap data in set_data_io with a DataChunkIterator to support overriding hdf5 dataset backend configurations #1172
Conversation
@oruebel, are there any problems with wrapping all data in a DataChunkIterator (numpy arrays, lists, tuples)? Should this fix be restricted to hdf5 datasets? |
Since the user has explicit control, I think this is fine. Also,, I believe it should work with numpy, lists, and tuples as well. |
Co-authored-by: Oliver Ruebel <[email protected]>
@oruebel, can you enable tests for this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1172 +/- ##
=======================================
Coverage 89.01% 89.02%
=======================================
Files 45 45
Lines 9872 9879 +7
Branches 2810 2812 +2
=======================================
+ Hits 8788 8795 +7
Misses 767 767
Partials 317 317 ☔ View full report in Codecov by Sentry. |
Looks like this is passing all the tests, can we merge? |
This looks good to me. |
Thank you @pauladkisson ! |
Motivation
Fixes #1170
Checklist
CHANGELOG.md
with your changes?