Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of extension classes that have references #1183

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 29, 2024

Motivation

Fix #1182

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (d378dec) to head (a9dd391).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1183      +/-   ##
==========================================
+ Coverage   88.92%   89.01%   +0.09%     
==========================================
  Files          45       45              
  Lines        9866     9872       +6     
  Branches     2806     2810       +4     
==========================================
+ Hits         8773     8788      +15     
+ Misses        776      767       -9     
  Partials      317      317              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from oruebel August 29, 2024 23:17
CHANGELOG.md Outdated Show resolved Hide resolved
oruebel
oruebel previously approved these changes Aug 29, 2024
Co-authored-by: Oliver Ruebel <[email protected]>
@rly rly merged commit 1fc6212 into dev Aug 30, 2024
29 checks passed
@rly rly deleted the fix_resolve_reference_types branch August 30, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot create classes from cached extensions with references to types defined in the extension
2 participants