-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Enh. DataChunkIterator, support: 1) h5 dataset, 2) skipping of blocks, 3) arbit. iter dim #132
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #132 +/- ##
==========================================
+ Coverage 68.74% 69.06% +0.31%
==========================================
Files 24 24
Lines 4918 4968 +50
Branches 1126 1137 +11
==========================================
+ Hits 3381 3431 +50
+ Misses 1172 1170 -2
- Partials 365 367 +2
Continue to review full report at Codecov.
|
…pping consecutive blocks of None values
If the first value returned by the iterator is None, then this error is generated:
If we can't get around this, it would be useful to raise a warning in the DataChunkIterator. |
TODO before review:
@oruebel could you take a look at my changes so far? it looks like everything works but i messed with the internal logic of |
@oruebel this is finally ready for review |
Motivation
Status Need to add tests to make sure this is working.
How to test the behavior?
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.