Infer dtype from data when spec dtype is none or numeric #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #143 +/- ##
======================================
+ Coverage 69% 69.2% +0.2%
======================================
Files 24 24
Lines 4971 4981 +10
Branches 1139 1143 +4
======================================
+ Hits 3430 3447 +17
+ Misses 1172 1168 -4
+ Partials 369 366 -3
Continue to review full report at Codecov.
|
|
I still need to add tests, but just wanted to put the proposed solution out there. |
|
I tested on my code and this PR solved the problem, related to #140 , thanks! |
ajtritt
approved these changes
Sep 26, 2019
This was referenced Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140 and fixes #142.
If an AbstractDataChunkIterator is used for a dataset that has the dtype 'numeric' or no dtype in the spec, then the dtype used to write the dataset will be inferred from the
dtypeof the AbstractDataChunkIterator. Same for all numpy types, lists and tuples, and Python primitives. Previously, the dtype used to write the dataset was set to None, and so I believe h5py used a default dtype of float32.