Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #154 . Add copy/deepcopy methods for DataChunk and add tests #155

Merged
merged 2 commits into from
Sep 27, 2019

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Sep 27, 2019

Motivation

Fix #154 copy and deepcopy for data chunk and add tests for DataChunk

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.

@oruebel oruebel requested review from rly and ajtritt September 27, 2019 18:40
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #155 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #155      +/-   ##
==========================================
+ Coverage   69.75%   69.78%   +0.03%     
==========================================
  Files          29       29              
  Lines        5736     5743       +7     
  Branches     1352     1352              
==========================================
+ Hits         4001     4008       +7     
  Misses       1307     1307              
  Partials      428      428
Impacted Files Coverage Δ
src/hdmf/data_utils.py 84.06% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c5ac9...4edc7ba. Read the comment docs.

@oruebel oruebel merged commit c551de2 into dev Sep 27, 2019
@oruebel oruebel deleted the fix/datachunkcopy branch September 27, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy of DataChunk broken
2 participants