Allow SZIP compression options #167
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #167 +/- ##
==========================================
+ Coverage 69.91% 69.97% +0.05%
==========================================
Files 30 30
Lines 5767 5785 +18
Branches 1355 1363 +8
==========================================
+ Hits 4032 4048 +16
Misses 1302 1302
- Partials 433 435 +2
Continue to review full report at Codecov.
|
|
@rly @bendichter @ajtritt could you check and approve. I had to dismiss your approval to fix a bug that Ben had found. |
| if not isinstance(self.__iosettings['compression_opts'], tuple) or \ | ||
| len(self.__iosettings['compression_opts']) != 2: | ||
| raise ValueError("SZIP compression filter compression_opts" + | ||
| " must be a 2-tuple ('ec'|'nn', even integer 0-32") |
There was a problem hiding this comment.
Super minor, but regarding code style, I'm pretty sure the backslash and plus symbols are not necessary.
PEP8 says: "The preferred way of wrapping long lines is by using Python's implied line continuation inside parentheses, brackets and braces. Long lines can be broken over multiple lines by wrapping expressions in parentheses. These should be used in preference to using a backslash for line continuation."
There was a problem hiding this comment.
You need an ending parenthesis inside the last quote marker on line 322
There was a problem hiding this comment.
Since we check for gzip compression opts being an int from 0-9, can we also check for the szip compression opts being ('ec'|'nn', even integer 0-32)?
There was a problem hiding this comment.
Not sure what the issue with 322 is?
szip compression opts being ('ec'|'nn', even integer 0-32)?
sure
There was a problem hiding this comment.
Not a syntax error - but within the string, the "(" before "'ec'" needs a corresponding ")".
Motivation
Fix #166
Enhance parameter checking in H5DataIO
Add tests for parameter checking
Checklist
flake8from the source directory.#XXXnotation whereXXXis the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.