Add export_spec utility function for use by extensions template #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #170 +/- ##
==========================================
+ Coverage 69.97% 70.02% +0.05%
==========================================
Files 30 30
Lines 5785 5802 +17
Branches 1363 1367 +4
==========================================
+ Hits 4048 4063 +15
- Misses 1302 1303 +1
- Partials 435 436 +1
Continue to review full report at Codecov.
|
oruebel
previously approved these changes
Oct 9, 2019
oruebel
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The https://github.com/nwb-extensions/ndx-template includes a utility function
export_specthat is intended not to be touched by the user. It should live elsewhere, and since it is a general purpose function regarding exporting extension specs, it should live in HDMF. This PR moves an adaptedexport_specfunction to HDMF, adds a test, and refactors the existing spec tests.