Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default ObjectMapping bug for DynamicTableRegion columns #171

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Oct 15, 2019

Motivation

The default mapping for DynamicTableRegion columns in the DynamicTable has a bug where we try to read the .table attribute from the VectorIndex instead of the VectorData dataset.

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.

@oruebel oruebel requested review from rly and ajtritt October 15, 2019 23:13
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #171 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #171      +/-   ##
==========================================
- Coverage   70.03%   70.01%   -0.03%     
==========================================
  Files          30       30              
  Lines        5811     5813       +2     
  Branches     1368     1369       +1     
==========================================
  Hits         4070     4070              
- Misses       1305     1307       +2     
  Partials      436      436
Impacted Files Coverage Δ
src/hdmf/common/io/table.py 55.55% <0%> (-3.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3500458...1f4f81b. Read the comment docs.

@oruebel oruebel merged commit 0022114 into dev Oct 15, 2019
@oruebel oruebel deleted the fix/dtrmapbug branch October 15, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants