Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundend shape check functions. Fix #204 #205

Merged
merged 4 commits into from
Nov 18, 2019

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 18, 2019

Fix #204

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.

@oruebel oruebel requested a review from rly November 18, 2019 20:05
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #205 into dev will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #205      +/-   ##
==========================================
- Coverage   70.34%   70.27%   -0.07%     
==========================================
  Files          30       30              
  Lines        5958     5938      -20     
  Branches     1399     1393       -6     
==========================================
- Hits         4191     4173      -18     
+ Misses       1329     1328       -1     
+ Partials      438      437       -1
Impacted Files Coverage Δ
src/hdmf/data_utils.py 90.8% <100%> (+0.21%) ⬆️
src/hdmf/backends/hdf5/h5tools.py 66.52% <100%> (ø) ⬆️
src/hdmf/validate/validator.py 69.27% <100%> (-0.1%) ⬇️
src/hdmf/container.py 68.47% <100%> (ø) ⬆️
src/hdmf/utils.py 89.61% <50%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1684a...78cda65. Read the comment docs.

@oruebel oruebel merged commit c93d595 into dev Nov 18, 2019
@oruebel oruebel deleted the enh/consolidate_shape_functs branch November 18, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace data_utils.get_shape with utils.get_data_shape
2 participants