Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #218. Set container_source to source for references #219

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 10, 2019

Fix #218. When handling references, calls to BuildManager.build now include a source parameter. container_source is then set appropriately on line 159.

@rly rly requested a review from ajtritt December 10, 2019 21:52
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #219 into dev will not change coverage.
The diff coverage is 12.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #219   +/-   ##
=======================================
  Coverage   70.38%   70.38%           
=======================================
  Files          31       31           
  Lines        5920     5920           
  Branches     1389     1389           
=======================================
  Hits         4167     4167           
  Misses       1322     1322           
  Partials      431      431
Impacted Files Coverage Δ
src/hdmf/build/map.py 66.96% <12.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448b467...72a8433. Read the comment docs.

@rly rly requested a review from a team December 18, 2019 21:55
@rly rly merged commit aa72504 into dev Dec 18, 2019
@rly rly deleted the fix/ref_source branch December 18, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container source not set for some references
2 participants