Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for release #641

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix CI for release #641

merged 1 commit into from
Jul 7, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 7, 2021

Motivation

The deploy-release job on CircleCI failed because InvalidDistribution: Cannot find file (or expand pattern): 'dist/*' because the distributions were saved in the wrong CI job. This PR should fix the issue.

https://app.circleci.com/pipelines/github/hdmf-dev/hdmf/3273/workflows/5024dee4-9cc7-4d0f-9a14-d34a27b4226e/jobs/37737

This PR will also be the last PR before releasing bugfix version 3.0.1 since 3.0.0 has already been tagged.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team July 7, 2021 05:57
@bendichter
Copy link
Contributor

@rly it looks like python39 is failing. Is that expected?

@rly
Copy link
Contributor Author

rly commented Jul 7, 2021

@rly it looks like python39 is failing. Is that expected?

The hdmf python 39 test succeeds but the pynwb-dev-python39 test falis. That is expected because the dev branch of pynwb uses h5py 2.10 which did not release wheels for python 3.9. (locally, pynwb tests pass with h5py 3, python 3.9)

@rly rly merged commit 935d983 into dev Jul 7, 2021
@rly rly deleted the fix/release_ci branch July 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants