Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build wheel for python 2, restrict to >=3.7 #642

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 7, 2021

Motivation

Released wheels are named hdmf-3.0.1-py2.py3-none-any.whl which means it can be installed on Python 2, but Python >=3.7 is required. This PR fixes the issue.

Also fixes a minor CI typo where the wrong tox environments were being run for a job.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team July 7, 2021 21:55
@rly rly merged commit d1ffe7e into dev Jul 8, 2021
@rly rly deleted the fix/py2_wheel branch July 8, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants