Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: e2e-tests: Improve code formatting #1809

Merged
merged 3 commits into from
Mar 18, 2024
Merged

frontend: e2e-tests: Improve code formatting #1809

merged 3 commits into from
Mar 18, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Mar 14, 2024 •
edited
Loading

  • Code formatting for e2e-tests folder will also be format checked on CI.
  • Some of the e2e test code was also formatted.
  • Use new cached option for prettier, format goes from 14seconds to 2 seconds.

npm run format Before

real    0m8.543s
user    0m14.382s
sys     0m0.842s

npm run format After

real    0m1.951s
user    0m2.218s
sys     0m0.356s

@illume illume marked this pull request as draft March 14, 2024 20:49
@illume illume added frontend Issues related to the frontend dx e2e-tests End to end tests plugins performance labels Mar 14, 2024
@illume illume requested a review from knrt10 March 14, 2024 21:45
@illume illume marked this pull request as ready for review March 14, 2024 21:56
@illume illume requested a review from vyncent-t March 14, 2024 21:56
knrt10
knrt10 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@illume
frontend: e2e-tests: Add e2e-tests to be code formatted
a686172 
It will also be format checked on CI.

Signed-off-by: René Dudfield <[email protected]>
@illume
frontend: Upgrade prettier to 2.7.1
93c2d49 
So it can use the cache option.

Signed-off-by: René Dudfield <[email protected]>
@illume
frontend: headlamp-plugin: Add speedup for code formatting
f309af8 
Signed-off-by: René Dudfield <[email protected]>
@illume illume merged commit 93fda6c into main Mar 18, 2024
8 of 9 checks passed
@illume illume deleted the e2e-test-formatting branch March 18, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrt10 knrt10 knrt10 approved these changes

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees
No one assigned
Labels
dx e2e-tests End to end tests frontend Issues related to the frontend performance plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illume @knrt10