frontend: Sidebar/VersionButton: Add support for multiple clusters #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: René Dudfield <[email protected]> Co-authored-by: René Dudfield <[email protected]> Signed-off-by: Joaquim Rocha <[email protected]>
dosubot
bot
added
the
size:XXL
illume
added
frontend
joaquimrocha
requested changes
Oct 30, 2024
Comment on lines
+58
to
+73
| // export const InClusterSidebarOpen = Template.bind({}); | ||
| // InClusterSidebarOpen.args = { | ||
| // isSidebarOpen: true, | ||
| // selected: { | ||
| // item: 'cluster', | ||
| // sidebar: DefaultSidebars.IN_CLUSTER, | ||
| // }, | ||
| // }; | ||
| // export const InClusterSidebarClosed = Template.bind({}); | ||
| // InClusterSidebarClosed.args = { | ||
| // isSidebarOpen: false, | ||
| // selected: { | ||
| // item: 'cluster', | ||
| // sidebar: DefaultSidebars.IN_CLUSTER, | ||
| // }, | ||
| // }; |
There was a problem hiding this comment.
These tests fail. Didn't look into why.
Comment on lines
+81
to
+89
| // export const SelectedItemWithSidebarOmitted = Template.bind({}); | ||
| // SelectedItemWithSidebarOmitted.args = { | ||
| // selected: { | ||
| // item: 'workloads', | ||
| // // This is what happens internally when plugins only set a selected name, not a selected sidebar. | ||
| // // i.e. it will use the in-cluster sidebar by default. | ||
| // sidebar: '', | ||
| // }, | ||
| // }; |
| @@ -62,49 +74,134 @@ export default function VersionButton() { | |||
| ]; | |||
| } | |||
|
|
|||
| const { data: clusterVersion } = useQuery({ | |||
There was a problem hiding this comment.
Maybe we should change by useQueries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Can someone please take this over?
This is causing some failing tests, see states which are commented out.
Probably this could be refactored to use the redux store for the version info so it's easier to test.
Because this component is included in the sidebar.
Or there's a different approach here: 85bdc1f
How to test
put two cluster context names in the URL eg, instead of "minikube" put "minikube+cluster1"