-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 Issue 41 #42
Closed
Closed
Patch 1 Issue 41 #42
Commits on Jun 18, 2014
-
Update SynonymExpandingExtendedDismaxQParserPlugin.java
Issue healthonnet#41, when original search term is quoted and synonym being expanded is item quoted don't re-quote when doing constructPhraseQueries. Removes issue where double quotes appear in result. Also when doing constructPhraseQueries, only quote phrases not single term synonyms.
Configuration menu - View commit details
-
Copy full SHA for 4866bd8 - Browse repository at this point
Copy the full SHA 4866bd8View commit details -
Stubbed out test case for issue healthonnet#41. Additional logic needs to be implemented for testing the results, see TODO. I've been unable to get Python(v3.4.1) to run the top level file, but am assuming that debugQuery needs to be set on and the contents of the 'expandedSynonyms' in the response needs to be analyized. Currently I'm assuming a count of the number of quotes would work, though the exact expected string could also be passed in.
Configuration menu - View commit details
-
Copy full SHA for 84a98d1 - Browse repository at this point
Copy the full SHA 84a98d1View commit details
Commits on Jun 24, 2014
-
Create run_solr_for_unit_tests_on_windows.py
Windows based python run script. Primary issue is doing 'cd' inside a os.system() call does not actually change the working directory. Instances of this have been replaced with os.chdir() prior to the calls.
Configuration menu - View commit details
-
Copy full SHA for 7af4b9d - Browse repository at this point
Copy the full SHA 7af4b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7217fd5 - Browse repository at this point
Copy the full SHA 7217fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7cd67 - Browse repository at this point
Copy the full SHA fe7cd67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e8ec56 - Browse repository at this point
Copy the full SHA 0e8ec56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c89b5d - Browse repository at this point
Copy the full SHA 0c89b5dView commit details -
Update SynonymExpandingExtendedDismaxQParserPlugin.java
Use a LinkedHashSet to buildUpAlternateQueries() rather than an ArrayList to ensure that our list of alternate queries that are built are unique.
Configuration menu - View commit details
-
Copy full SHA for 9e6efe4 - Browse repository at this point
Copy the full SHA 9e6efe4View commit details -
Added logic needed to validate quote change. had to resort to using urllib logic and wt=pthon in the url inorder to gain access to the debug information generated in the SOLR response. The solrpy Response object was not detailed enough.
Configuration menu - View commit details
-
Copy full SHA for fc3ced0 - Browse repository at this point
Copy the full SHA fc3ced0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.