Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cocoapods generates a new checksum on every pod install #400

Closed
guy-shahine opened this issue Aug 11, 2023 · 1 comment · Fixed by #409
Closed

Cocoapods generates a new checksum on every pod install #400

guy-shahine opened this issue Aug 11, 2023 · 1 comment · Fixed by #409

Comments

@guy-shahine
Copy link

Using the same npm version of react-native-heap package, every time we run pod install a new checksum is generated. This behavior is odd and causing our CI machines to raise alerts because it's detected new changes in lock files. Do we know the reason for this issue that does not happen with other packages we use? Thank you
@dauby88
Copy link

dauby88 commented Sep 8, 2023 •
edited
Loading

We have the same issue. I suspect it's the same issue that's resolved here: facebook/react-native#31121 (comment)

I haven't tried it yet, but I'm guessing we need to change line 3 of the Podspec from:
json = File.read(File.join(__dir__, "package.json"))
To:
json = File.read(File.join("$PODS_TARGET_SRCROOT/../../", "package.json"))

bnickel added a commit that referenced this issue Sep 26, 2023
@bnickel
[HEAP-48203] Produce a consistent Cocoapods checksum
b48efa0 
[HEAP-48203](https://heapinc.atlassian.net/browse/HEAP-48203)

Reported in #400, the podspec was generating a new checksum on different devices.  The issue is that we were using `path => '.'` instead of `:path => '.'`, which caused the `path` variable to expand as a key.  I've updated to the source repository to match what the modern template does.  It doesn't affect behavior, since `source` is ignored for local podspecs.
@bnickel bnickel mentioned this issue Sep 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HEAP-48203] Produce a consistent Cocoapods checksum heap/react-native-heap
2 participants
@guy-shahine @dauby88